Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant constraints from cabal.project #721

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Remove redundant constraints from cabal.project #721

merged 1 commit into from
Jan 14, 2025

Conversation

neilmayhew
Copy link
Contributor

cabal-doctest has now been fixed

Changelog

- description: |
    Remove redundant constraints from cabal.project
# uncomment types applicable to the change:
  type:
  - maintenance    # not directly related to the code

Context

This constraint was added in e8da976 to work around a temporary problem.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@neilmayhew
Remove redundant constraints from cabal.project
21d4cbb 
`cabal-doctest` has now been fixed
@smelc smelc added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 13, 2025
@carbolymer carbolymer added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 14, 2025
@carbolymer carbolymer merged commit b0547c1 into master Jan 14, 2025
70 checks passed
@carbolymer carbolymer deleted the neilmayhew/cabal-project-constraints branch January 14, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@carbolymer carbolymer carbolymer approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilmayhew @carbolymer @smelc